Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas/PETSc issues #1136

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Fix pandas/PETSc issues #1136

merged 11 commits into from
Nov 2, 2023

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Nov 2, 2023

TODOs:

  • fix the rest of the failing tests
  • fix PETSc >= 3.20
  • fix some warnings in tests

closes #1128
closes #1134

@michalk8 michalk8 added the bug Something isn't working label Nov 2, 2023
@michalk8 michalk8 self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1136 (8043c9c) into main (f3a6a0e) will increase coverage by 1.27%.
The diff coverage is 74.35%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
+ Coverage   79.37%   80.65%   +1.27%     
==========================================
  Files          51       51              
  Lines        8483     8491       +8     
  Branches     1645     2218     +573     
==========================================
+ Hits         6733     6848     +115     
+ Misses       1207     1101     -106     
+ Partials      543      542       -1     
Files Coverage Δ
src/cellrank/kernels/_precomputed_kernel.py 94.11% <100.00%> (ø)
src/cellrank/pl/_aggregate_fate_probs.py 87.29% <100.00%> (ø)
src/cellrank/pl/_heatmap.py 96.12% <100.00%> (ø)
src/cellrank/_utils/_colors.py 81.20% <66.66%> (ø)
src/cellrank/_utils/_lineage.py 84.94% <94.44%> (+0.04%) ⬆️
src/cellrank/_utils/_linear_solver.py 93.58% <80.00%> (+52.50%) ⬆️
.../cellrank/estimators/mixins/_fate_probabilities.py 83.75% <50.00%> (ø)
src/cellrank/estimators/terminal_states/_gpcca.py 78.21% <75.00%> (ø)
src/cellrank/kernels/_utils.py 63.41% <80.00%> (ø)
src/cellrank/kernels/utils/_random_walk.py 77.41% <75.00%> (+0.14%) ⬆️
... and 7 more

... and 5 files with indirect coverage changes

@michalk8 michalk8 changed the title Fix/pandas version Fix pandas/PETSc issues Nov 2, 2023
@michalk8 michalk8 merged commit 01a79ca into main Nov 2, 2023
8 checks passed
@michalk8 michalk8 deleted the fix/pandas-version branch November 2, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

petsc4py error when running "compute_fate_probabilities" Fix pandas>=2.1.1
1 participant