Add CBC score #1168
Merged
Add CBC score #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeilerP
commented
Feb 23, 2024
WeilerP
commented
Feb 23, 2024
WeilerP
commented
Feb 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
+ Coverage 80.69% 80.76% +0.07%
==========================================
Files 51 51
Lines 8566 8606 +40
Branches 2234 2237 +3
==========================================
+ Hits 6912 6951 +39
Misses 1102 1102
- Partials 552 553 +1
|
michalk8
requested changes
Feb 24, 2024
|
I'll add the tests ASAP, @michalk8. Can you briefly comment on the Pearson correlation part? |
michalk8
requested changes
Feb 29, 2024
Adds function to identify observations at the boundary of two clusters.
Add `KernelExpression` class method to estimate the empirical velocity field of boundary cells in the source region towards a target cluster.
Adds `KernelExpression` class method to estimate velocity field based on a single step under the transition matrix.
Add class method for computing cross-boundary correctness score.
* Make function private. * Rename argument `graph` to `graph_key`. * Add return type. * Update docstrings. * Change definition of `source_ids`. * Update identification of boundary IDs.
* Make function private. * Rename argument `graph` to `graph_key`. * Finish type hints. * Update docstrings. * Simplify computation of empirical velocity estimates.
* Make function private. * Add return type. * Update docstrings.
* Add return type. * Rename argument `graph` to `graph_key`. * Update docstrings. * Rename and refactor `get_pearson_corr`.
* Rename function to `cbc`. * Update docstrings. * Refactor `_pearsonr`. * Remove redundant code. * Add TODO comment.
* Refactor definition of `empirical_velo`.
Remove redundant code; `target` is always a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes
Closes #1167.