Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tsi unsetting #1174

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix/tsi unsetting #1174

merged 2 commits into from
Mar 4, 2024

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Mar 4, 2024

Update tsi to use temporary GPCCA object, fix a typo.

@michalk8 michalk8 self-assigned this Mar 4, 2024
@michalk8 michalk8 requested a review from WeilerP March 4, 2024 17:36
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (696a23b) to head (a0c1c1c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   80.76%   80.77%           
=======================================
  Files          51       51           
  Lines        8606     8607    +1     
  Branches     2237     2237           
=======================================
+ Hits         6951     6952    +1     
  Misses       1102     1102           
  Partials      553      553           
Files Coverage Δ
src/cellrank/estimators/terminal_states/_gpcca.py 78.79% <100.00%> (+0.03%) ⬆️

Copy link
Member

@WeilerP WeilerP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @michalk8!

@WeilerP WeilerP merged commit 3b8e314 into main Mar 4, 2024
8 of 9 checks passed
@WeilerP WeilerP deleted the fix/tsi-unsetting branch March 4, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants