Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extraction of corf_loc_names when dmat is provided directly #174

Closed
wants to merge 17 commits into from
Closed

fix extraction of corf_loc_names when dmat is provided directly #174

wants to merge 17 commits into from

Conversation

le-ander
Copy link
Member

when dmat is provided directly to the wald test, an error is thrown because the code further down in the function expected dmat to be a pandas dataframe.

@le-ander le-ander requested a review from davidsebfischer July 30, 2020 10:58
@davidsebfischer davidsebfischer changed the base branch from master to dev July 30, 2020 14:07
@davidsebfischer
Copy link
Contributor

Awesome, thanks a lot @le-ander! Could you merge dev into your branch and make sure the .rst is not changed? I channel all changes through dev to get the releases right.

@le-ander
Copy link
Member Author

umm, I am a bit confused.

I can just make the change again on my dev and create a new pull request onto your dev. Would that be the easiest?

@le-ander
Copy link
Member Author

superseeded by #204

@le-ander le-ander closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants