Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow csc_matrix input for rank and ttest #175

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ivirshup
Copy link

@ivirshup ivirshup commented Aug 3, 2020

As title.

I've mostly done spot checks, and have given updating the tests a shot. I'm not able to get passing tests even without the changes, so not sure what to do about that.

@davidsebfischer
Copy link
Contributor

Thanks @ivirshup! Which unit test did not work for you?

@ivirshup
Copy link
Author

ivirshup commented Aug 5, 2020

Most of them seem to be failing, here's the summary from running pytest at the root of the repo:

diffxpy/unit_test/test_acc_glm_all_numpy_temp.py F                                                                      [  1%]
diffxpy/unit_test/test_backends.py .FF                                                                                  [  5%]
diffxpy/unit_test/test_constrained.py FFF                                                                               [ 10%]
diffxpy/unit_test/test_continuous_de.py .F                                                                                         [ 13%]
diffxpy/unit_test/test_continuous_null.py ...                                                                                      [ 17%]
diffxpy/unit_test/test_data_types.py FF                                                                                            [ 20%]
diffxpy/unit_test/test_enrich.py F                                                                                                 [ 22%]
diffxpy/unit_test/test_extreme_values.py FF                                                                                        [ 25%]
diffxpy/unit_test/test_fit.py FFFFFF                                                                                               [ 33%]
diffxpy/unit_test/test_numeric_covar.py .                                                                                          [ 35%]
diffxpy/unit_test/test_pairwise_null.py FFF.FF                                                                                     [ 44%]
diffxpy/unit_test/test_partition.py FFFFF                                                                                          [ 51%]
diffxpy/unit_test/test_single_de.py FFF.FF                                                                                         [ 60%]
diffxpy/unit_test/test_single_external_libs.py .F                                                                                  [ 63%]
diffxpy/unit_test/test_single_fullrank.py .                                                                                        [ 64%]
diffxpy/unit_test/test_single_null.py FFF...FFF                                                                                    [ 77%]
diffxpy/unit_test/test_single_sf_null.py FF                                                                                        [ 80%]
diffxpy/unit_test/test_stats.py .....                                                                                              [ 88%]
diffxpy/unit_test/test_twosample.py ....                                                                                           [ 94%]
diffxpy/unit_test/test_vsrest.py FFFF                                                                                              [100%]

Here's a gist with the full output.

@davidsebfischer
Copy link
Contributor

a couple of them are failing because there is paths in there specific to my machine because i need file IO for those tests, i have only been running the unit tests locally so far, will look into getting pytest to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants