Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation warnings #416

Closed
Zethson opened this issue Oct 25, 2022 · 4 comments
Closed

Documentation warnings #416

Zethson opened this issue Oct 25, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Zethson
Copy link
Member

Zethson commented Oct 25, 2022

WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT": name 'Vocab' is not defined
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.create_vocabulary": name 'Vocab' is not defined
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.load_concept_db": name 'CDB' is not defined
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.load_vocabulary": name 'Vocab' is not defined
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.save_vocabulary": name 'Vocab' is not defined
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.update_cat": name 'Vocab' is not defined
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.update_cat_config": name 'Config' is not defined
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:48: WARNING: Explicit markup ends without a blank line; unexpected unindent.
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.create_vocabulary": name 'Vocab' is not defined
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:52: WARNING: Explicit markup ends without a blank line; unexpected unindent.
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.load_concept_db": name 'CDB' is not defined
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:56: WARNING: Explicit markup ends without a blank line; unexpected unindent.
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.load_vocabulary": name 'Vocab' is not defined
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:60: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:64: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:68: WARNING: Explicit markup ends without a blank line; unexpected unindent.
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.save_vocabulary": name 'Vocab' is not defined
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:72: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:76: WARNING: Explicit markup ends without a blank line; unexpected unindent.
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.update_cat": name 'Vocab' is not defined
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.MedCAT.rst:80: WARNING: Explicit markup ends without a blank line; unexpected unindent.
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT.update_cat_config": name 'Config' is not defined
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.Translator.rst:42: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.Translator.rst:46: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/zeth/PycharmProjects/ehrapy/docs/usage/tools/ehrapy.tools.Translator.rst:50: WARNING: Explicit markup ends without a blank line; unexpected unindent.
WARNING: Cannot resolve forward reference in type annotations of "ehrapy.tools.MedCAT": name 'Vocab' is not defined

Think that these could be solved with smarter imports.

@Zethson Zethson added the bug Something isn't working label Oct 25, 2022
@Zethson Zethson assigned eroell and unassigned Imipenem Oct 19, 2023
@eroell
Copy link
Collaborator

eroell commented Nov 1, 2023

Maybe a naive question, what are the reasons to not add medcat to the doc-dependencies list?

@Zethson
Copy link
Member Author

Zethson commented Nov 1, 2023

I don't think that this is a naive question at all. medcat is faaaaaat and I didn't want everyone to have to install it...

@eroell
Copy link
Collaborator

eroell commented Nov 1, 2023

Would it make sense to add it for people that intend to build the docs? (just to make sure, a user install does not by default install the doc requirements right)
From a first thought, these people likely

  • are not the majority
  • are involved enough to accept some heavy packages
  • might consider error messages everytime when building the doc a larger nuisance than a 1x install

What are your thoughts on this?

@Zethson
Copy link
Member Author

Zethson commented Nov 1, 2023

Yeah, I probably agree. It pains me, but it is for the better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants