Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add medcat to doc dependency list #605

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

eroell
Copy link
Collaborator

@eroell eroell commented Nov 1, 2023

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes
Adresses issue #416 .
This could be a way of omitting the medcat warnings when building the docs.

Technical details
None?

Additional context
Medcat is a big package, and will add additional installation overhead when intending to install the doc dependencies.
However, it will reduce the number of warnings when building the documentation.

@eroell
Copy link
Collaborator Author

eroell commented Nov 1, 2023

Draft PR to deposit this suggestion. Might re-discuss if really want this & whether more warnings can be caught here.

@eroell eroell marked this pull request as draft November 1, 2023 21:18
@Zethson
Copy link
Member

Zethson commented Nov 2, 2023

I don't think it works like this. With ehrapy[medcat] it will attempt to install all of ehrapy from the current pypi version (that may have different requirements than the development version) and the medcat extra. However, we only want the medcat extra.

@Zethson
Copy link
Member

Zethson commented Nov 2, 2023

CI failures are unrelated and tracked on AnnData

@Zethson Zethson marked this pull request as ready for review March 8, 2024 16:19
@Zethson Zethson merged commit 15311b4 into theislab:main Mar 8, 2024
6 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants