Improve survival analysis interface #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @aGuyLearning, awesome! Comments as per review :) |
eroell
requested changes
Nov 13, 2024
ehrapy/tools/_sa.py
Outdated
| model = model_class() | ||
| model.fit(T, event_observed=E) | ||
| model.fit( |
There was a problem hiding this comment.
Add fit_left_censoring call upon argument input left
There was a problem hiding this comment.
check if nelson-aalen gracefully crashes with meaningful error message
- removed kwargs - updated documentation
|
On a sidenote: having a descriptive PR title is better here - the titles end up in the changelog, forgot to mention |
|
imblearn maintenance for sklearn usage (failing test) which @aGuyLearning noted is on the way btw |
eroell
requested changes
Nov 20, 2024
… function in line with new signature
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
eroell
reviewed
Nov 27, 2024
eroell
reviewed
Nov 27, 2024
eroell
reviewed
Nov 27, 2024
eroell
reviewed
Nov 27, 2024
eroell
reviewed
Nov 27, 2024
|
FYI: I merged main into this PR because I fixed the RTD build. |
Zethson
reviewed
Nov 28, 2024
|
Objections to lifeline's intersphinx mappings @Zethson? |
Zethson
approved these changes
Dec 2, 2024
eroell
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
closes #822
Changed the method signature of univariate models to allow the user to pass parameters to the lifeline. Now weilbull, neil_aalen and kmf look like
adata: AnnData, duration_col: str, event_col: str, **kwargsand are passed on to the _univariate_model function
Technical details
this could be changed to explicitly have all parameters in each function and pass them on.
Additional context