Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend cell cycle gene scoring #421

Merged
merged 12 commits into from
Jan 13, 2025
Merged

Extend cell cycle gene scoring #421

merged 12 commits into from
Jan 13, 2025

Conversation

mumichae
Copy link
Collaborator

  • add new organism gene sets
  • smarter gene ID/ gene name usage

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.44%. Comparing base (e614d35) to head (92b9ebf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scib/preprocessing.py 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   58.93%   59.44%   +0.51%     
==========================================
  Files          22       22              
  Lines        1690     1709      +19     
==========================================
+ Hits          996     1016      +20     
+ Misses        694      693       -1     
Flag Coverage Δ
unittests 59.44% <93.54%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scib/preprocessing.py 23.35% <93.54%> (+4.29%) ⬆️

Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks great! I added a few minor comments to improve readability. Would be great to resolve them before merging

scib/preprocessing.py Outdated Show resolved Hide resolved
scib/preprocessing.py Outdated Show resolved Hide resolved
scib/preprocessing.py Show resolved Hide resolved
scib/preprocessing.py Outdated Show resolved Hide resolved
scib/resources/convert_genes.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/preprocessing/test_gene_scoring.py Show resolved Hide resolved
Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mumichae mumichae merged commit 203b94f into main Jan 13, 2025
11 checks passed
@mumichae mumichae deleted the extend_cell_cycle_genes branch January 13, 2025 18:35
@mumichae mumichae restored the extend_cell_cycle_genes branch January 14, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants