Allow hostnames to have dot and dash #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously keys that were namespaced with hostnames with dashes or dots in their names were ignored and merged into __default namespace.
|
@zpieslak thank you for the PR! I'm going to have to think on this one as dots and dashes are considered "special" in delimiting possible future information I might want to put in the key filename. For example, I just added per-environment key pairs. What about if, instead of allowing them in the filename, I stripped them from the host name? So instead of |
|
@jfelchner My current situation is that I have a host, which consists multiple environments with very similar credentials. Obviously I can create multiple settings-environment.yml files but this will require multiple key-pairs and duplicate all credentials that suppose to be common for this host. I wanted to avoid that. So If understand your idea correctly, the host will still be allowed to have dots and dashes, but the filename will need to be stripped (i.e when calling Thanks! |
jfelchner
force-pushed
the
master
branch
2 times, most recently
from
a8271bb to
bc074c8
Compare
jfelchner
pushed a commit
that referenced
this pull request
May 29, 2019
Why This Change Is Necessary ======================================================================== Previously dots and dashes were not removed from the hostname, which caused an issue where the namespaced filenames were not accurate. We consider dots and dashes to be special characters in Chamber filenames and cannot have them used within namespaces. How These Changes Address the Issue ======================================================================== This change removes dots and dashes from the hostname we've looked up. Side Effects Caused By This Change ======================================================================== Anyone relying on the erroneous functionality will break. ------------------------------------------------------------------------ Actions: * References #56
|
As soon as I released 2.12.4 I realized that this was a backwards incompatible change. I'll be releasing 2.12.5 in a few minutes. Check out the commit message for more details. |
jfelchner
added a commit
that referenced
this pull request
May 29, 2019
Why This Change Is Necessary ======================================================================== Previously dots and dashes were not removed from the namespaces when looking up the filenames for keys. This meant that when looking up filenames for those namespaces, the per-namespace keys were not resolving correctly. How These Changes Address the Issue ======================================================================== This change removes dots and dashes from the namespaces when looking up key filenames. Side Effects Caused By This Change ======================================================================== Anyone relying on the erroneous functionality will break. ------------------------------------------------------------------------ Actions: * References #56
jfelchner
added a commit
that referenced
this pull request
May 29, 2019
Why This Change Is Necessary ======================================================================== Previously dots and dashes were not removed from the namespaces when looking up the filenames for keys. This meant that when looking up filenames for those namespaces, the per-namespace keys were not resolving correctly. How These Changes Address the Issue ======================================================================== This change removes dots and dashes from the namespaces when looking up key filenames. We also alter the script that generates key pairs so that it removes dots and dashes from the filenames it generates. Caveat ======================================================================== It's important to note that this _only_ applies to looking up the key filename. Inside the YAML files, dots and dashes are valid characters and will be used when finding namespaced settings. With a namespace of `example-host.com`, the private key filename would be `.chamber.examplehostcom.pem`, however in the YAML file, you would still do: ```yaml example-host.com: my_setting: 'hello' ``` Side Effects Caused By This Change ======================================================================== Anyone relying on the erroneous functionality will break. ------------------------------------------------------------------------ Actions: * References #56
jfelchner
added a commit
that referenced
this pull request
May 29, 2019
Why This Change Is Necessary ======================================================================== Previously dots and dashes were not removed from the namespaces when looking up the filenames for keys. This meant that when looking up filenames for those namespaces, the per-namespace keys were not resolving correctly. How These Changes Address the Issue ======================================================================== This change removes dots and dashes from the namespaces when looking up key filenames. We also alter the script that generates key pairs so that it removes dots and dashes from the filenames it generates. Caveat ======================================================================== It's important to note that this _only_ applies to looking up the key filename. Inside the YAML files, dots and dashes are valid characters and will be used when finding namespaced settings. With a namespace of `example-host.com`, the private key filename would be `.chamber.examplehostcom.pem`, however in the YAML file, you would still do: ```yaml example-host.com: my_setting: 'hello' ``` Side Effects Caused By This Change ======================================================================== Anyone relying on the erroneous functionality will break. ------------------------------------------------------------------------ Actions: * References #56
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why This Change Is Necessary
Previously keys that were namespaced with hostnames with dashes or
dots in their names were ignored and merged into __default namespace.
It allows to use keys with hostanames with dots or dashes.