Removed named-regexp dependency and java version 1.6 to 1.7 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anthonycorbacho Its possible to merge this pull request and release new version ,Hope this will improve CPU performance. |
|
👍 on this. |
|
@anthonycorbacho any chances of merging this? |
|
Sorry i totally forgot about this PR.. looks great thank you for the contrib. |
|
would it be worth push this into Maven Central as version 0.2.0 by any chance (assuming some semantic versioning due to the major change from JRE6 to JRE7 and above)? |
|
(thanks for the merge by the way) |
Closed
This was referenced Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anthonycorbacho Its possible to merge my commit to remove dependency of named-regex lib