Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support purge operation in the gRPC server #448

Merged
merged 5 commits into from
May 12, 2022
Merged

Support purge operation in the gRPC server #448

merged 5 commits into from
May 12, 2022

Conversation

adejanovski
Copy link
Contributor

@adejanovski adejanovski commented Mar 8, 2022 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1384
┆priority: Medium

@adejanovski adejanovski mentioned this pull request Mar 8, 2022
Merged
5 tasks
@adejanovski adejanovski requested a review from jeffbanks March 8, 2022 17:31
@adejanovski adejanovski force-pushed the alex/grpc-purge-new branch from d7aa43d to 3c44e76 Compare April 30, 2022 09:15
@adejanovski adejanovski force-pushed the alex/grpc-purge-new branch from 3c44e76 to 80fc099 Compare May 10, 2022 07:31
@adejanovski
Copy link
Contributor Author

I've just rebased to fix the conflicts.
@jeffbanks, do you have spare cycles to review this?

jeffbanks
jeffbanks suggested changes May 10, 2022
View reviewed changes
Copy link
Contributor

@jeffbanks jeffbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits mostly, nice work!

I do have a question about the sync vs. async approach for the purge operation and how that varies with the options for the backup operations.

medusa/service/grpc/client.py Outdated Show resolved Hide resolved
medusa/service/grpc/medusa.proto Show resolved Hide resolved
medusa/service/grpc/medusa.proto Show resolved Hide resolved
medusa/service/grpc/medusa_pb2_grpc.py Show resolved Hide resolved
@jeffbanks jeffbanks requested review from burmanm and jeffbanks May 10, 2022 14:55
jeffbanks
jeffbanks approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@jeffbanks jeffbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for answering my open questions!

@adejanovski
Allow remote restore in Kubernetes (#449)
39472f1 
* Enable remote restores in kubernetes
* Fix concurrency setting not being propagated to GCS restores
* Fix the grpc check for backup existence to actually list backups
* Use dnspython to correctly resolve ips to hostnames in Kubernetes
* Disable debian focal package build as it is broken in CI
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 13 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adejanovski adejanovski merged commit bb628b8 into master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffbanks jeffbanks jeffbanks approved these changes

@burmanm burmanm Awaiting requested review from burmanm

Assignees
No one assigned
Labels
zh:Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adejanovski @jeffbanks