Cassandra backend improvements (#109)

* Cassandra performance: Replace sequence ids with time-based UUIDs
  Makes the schema changes in a separate migration step, so that data in the repair_unit and repair_schedule tables can be migrated over.

ref:
 - #99
 - #94
 - #99 (comment)

* Simplify the creation of repair runs and their segments.
 Repair runs and their segments are one unit of work in concept and the persistence layer should be designed accordingly.
 Previous they were separated because the concern of sequence generation for IDs were exposed in the code. This is now encapsulated within storage implementations.
 This work allows the CassandraStorage to implement segments as clustering keys within the repair_run table.

ref:
 - #94
 - #101

* In CassandraStorage implement segments as clustering keys within the repair_run table.
Change required in IStorage so to identify a segment both by runId and segmentId.

ref:
 - #94
 - #102

* Fix number of parallel repair computation
Downgrade to Dropwizard 1.0.7 and Guava 19.0 to fix dependency issues
Make repair manager schedule cycle configurable (was 30s hardcoded)

ref: #108

* In CassandraStorage replace the table scan on `repair_run` with a async break-down of per cluster run-throughs of known run IDs.

 ref: #105

pom.xml

@@ -11,7 +11,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <dropwizard.version>1.1.0</dropwizard.version>
+        <dropwizard.version>1.0.7</dropwizard.version>
         <dropwizard.cassandra.version>4.1.0</dropwizard.cassandra.version>
         <cassandra.version>2.2.7</cassandra.version>
         <cucumber.version>1.2.5</cucumber.version>

resource/cassandra-reaper-cassandra-ssl.yaml

@@ -12,6 +12,7 @@ enableCrossOrigin: true
 incrementalRepair: false
 allowUnreachableNodes: false
 enableDynamicSeedList: true
+repairManagerSchedulingIntervalSeconds: 30
 
 jmxPorts:
   127.0.0.1: 7198

resource/cassandra-reaper-cassandra.yaml

@@ -12,6 +12,7 @@ enableCrossOrigin: true
 incrementalRepair: false
 allowUnreachableNodes: false
 enableDynamicSeedList: true
+repairManagerSchedulingIntervalSeconds: 30
 
 jmxPorts:
   127.0.0.1: 7100

resource/cassandra-reaper-h2.yaml

@@ -12,6 +12,7 @@ enableCrossOrigin: true
 incrementalRepair: false
 allowUnreachableNodes: false
 enableDynamicSeedList: true
+repairManagerSchedulingIntervalSeconds: 30
 
 jmxPorts:
   127.0.0.1: 7100

resource/cassandra-reaper-memory.yaml

@@ -12,6 +12,7 @@ enableCrossOrigin: true
 incrementalRepair: false
 allowUnreachableNodes: false
 enableDynamicSeedList: true
+repairManagerSchedulingIntervalSeconds: 30
 
 jmxPorts:
   127.0.0.1: 7100

resource/cassandra-reaper-postgres.yaml

@@ -12,6 +12,7 @@ enableCrossOrigin: true
 incrementalRepair: false
 allowUnreachableNodes: false
 enableDynamicSeedList: true
+repairManagerSchedulingIntervalSeconds: 30
 
 jmxPorts:
   127.0.0.1: 7100

resource/cassandra-reaper.yaml

@@ -12,6 +12,7 @@ enableCrossOrigin: true
 incrementalRepair: false
 allowUnreachableNodes: false
 enableDynamicSeedList: true
+repairManagerSchedulingIntervalSeconds: 30
 
 jmxPorts:
   127.0.0.1: 7100

src/main/java/com/spotify/reaper/ReaperApplication.java

@@ -122,7 +122,7 @@ public void run(ReaperApplicationConfiguration config,
     context.repairManager.initializeThreadPool(
         config.getRepairRunThreadCount(),
         config.getHangingRepairTimeoutMins(), TimeUnit.MINUTES,
-        30, TimeUnit.SECONDS);
+        config.getRepairManagerSchedulingIntervalSeconds(), TimeUnit.SECONDS);
 
     if (context.storage == null) {
       LOG.info("initializing storage of type: {}", config.getStorageType());

src/main/java/com/spotify/reaper/ReaperApplicationConfiguration.java

@@ -73,7 +73,7 @@ public class ReaperApplicationConfiguration extends Configuration {
 
   private String enableCrossOrigin;
 
-  
+
   @JsonProperty
   private DataSourceFactory database = new DataSourceFactory();
 
@@ -86,14 +86,17 @@ public class ReaperApplicationConfiguration extends Configuration {
   @JsonProperty
   @DefaultValue("false")
   private Boolean allowUnreachableNodes;
-  
+
   @JsonProperty
   private AutoSchedulingConfiguration autoScheduling;
-  
+
   @JsonProperty
   @DefaultValue("true")
   private Boolean enableDynamicSeedList;
 
+  @JsonProperty
+  private Integer repairManagerSchedulingIntervalSeconds;
+
   public int getSegmentCount() {
     return segmentCount;
   }
@@ -117,15 +120,15 @@ public double getRepairIntensity() {
   public void setRepairIntensity(double repairIntensity) {
     this.repairIntensity = repairIntensity;
   }
-  
+
   public Boolean getIncrementalRepair() {
 	    return incrementalRepair;
   }
 
   public void setIncrementalRepair(Boolean incrementalRepair) {
 	    this.incrementalRepair = incrementalRepair;
   }
-  
+
   public Integer getScheduleDaysBetween() {
     return scheduleDaysBetween;
   }
@@ -170,13 +173,13 @@ public void setDataSourceFactory(DataSourceFactory database) {
     this.database = database;
   }
 
-  public int getHangingRepairTimeoutMins() {
-    return hangingRepairTimeoutMins;
+  public int getRepairManagerSchedulingIntervalSeconds() {
+    return this.repairManagerSchedulingIntervalSeconds==null?30:this.repairManagerSchedulingIntervalSeconds;
   }
 
   @JsonProperty
-  public void setHangingRepairTimeoutMins(int hangingRepairTimeoutMins) {
-    this.hangingRepairTimeoutMins = hangingRepairTimeoutMins;
+  public void setRepairManagerSchedulingIntervalSeconds(int repairManagerSchedulingIntervalSeconds) {
+    this.repairManagerSchedulingIntervalSeconds = repairManagerSchedulingIntervalSeconds;
   }
 
   public Map<String, Integer> getJmxPorts() {
@@ -206,11 +209,11 @@ public AutoSchedulingConfiguration getAutoScheduling() {
   public void setAutoScheduling(AutoSchedulingConfiguration autoRepairScheduling) {
     this.autoScheduling = autoRepairScheduling;
   }
-  
+
   public void setEnableDynamicSeedList(Boolean enableDynamicSeedList) {
     this.enableDynamicSeedList = enableDynamicSeedList;
   }
-  
+
   public Boolean getEnableDynamicSeedList() {
     return this.enableDynamicSeedList==null?Boolean.TRUE:this.enableDynamicSeedList;
   }
@@ -239,8 +242,8 @@ public String getPassword() {
     }
 
   }
-  
- 
+
+
   private CassandraFactory cassandra = new CassandraFactory();
 
   @JsonProperty("cassandra")
@@ -252,15 +255,24 @@ public CassandraFactory getCassandraFactory() {
   public void setCassandraFactory(CassandraFactory cassandra) {
       this.cassandra = cassandra;
   }
-  
+
   public Boolean getAllowUnreachableNodes() {
-    return allowUnreachableNodes;
+    return allowUnreachableNodes != null ? allowUnreachableNodes : false;
   }
 
   public void setAllowUnreachableNodes(Boolean allow) {
     this.allowUnreachableNodes = allow;
   }
-
+
+  public int getHangingRepairTimeoutMins() {
+    return hangingRepairTimeoutMins;
+  }
+
+  @JsonProperty
+  public void setHangingRepairTimeoutMins(int hangingRepairTimeoutMins) {
+    this.hangingRepairTimeoutMins = hangingRepairTimeoutMins;
+  }
+
   public static class AutoSchedulingConfiguration {
 
     @JsonProperty
@@ -277,7 +289,7 @@ public static class AutoSchedulingConfiguration {
 
     @JsonProperty
     private Duration scheduleSpreadPeriod;
-    
+
     @JsonProperty
     private List<String> excludedKeyspaces = Collections.emptyList();
 
@@ -324,7 +336,7 @@ public void setScheduleSpreadPeriod(Duration scheduleSpreadPeriod) {
     public boolean hasScheduleSpreadPeriod() {
       return scheduleSpreadPeriod != null;
     }
-    
+
     public void setExcludedKeyspaces(List<String> excludedKeyspaces) {
       this.excludedKeyspaces = excludedKeyspaces;
     }