Cassandra performance: repair_id prepared statements against repair_id & cache sequence #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsembwever
force-pushed
the
mck/cassandra-prepared-and-cached-repair-id
branch
from
b629e11 to
504e937
Compare
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
adejanovski
reviewed
May 9, 2017
| Preconditions.checkState(idValue < Long.MAX_VALUE); | ||
| attempts++; | ||
| if(10 <= attempts && 0 == attempts % 10){ | ||
| LOG.warn("still cant find a new repairId after " + attempts + " attempts"); |
There was a problem hiding this comment.
There was a problem hiding this comment.
of little concern. WARN is generally always enabled, and the frequency of this log line low.
|
Tested against creating (but not activating) a non-incremental repair with 1467 segments. Before there was 14179 cql requests, after the patch only 5915 cql requests. |
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
tlpsonarqube
reviewed
May 9, 2017
| Preconditions.checkState(idValue < Long.MAX_VALUE); | ||
| attempts++; | ||
| if(10 <= attempts && 0 == attempts % 10){ | ||
| LOG.warn("still cant find a new repairId after " + attempts + " attempts"); |
There was a problem hiding this comment.
|
LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use prepared statements against repair_id, and cache a floor for the sequence number to reduce lookups.
ref: #94