Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset axis mappings and instance coordinates #31

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Conversation

alerque
Copy link
Member

@alerque alerque commented Oct 27, 2020

This is my attempt to fix #29 (again), this time from Glyphs.app:

  1. Open axis mappings and set all values to 1→1 mappings. Note that on the Glyphs axis graph this ended up with a straight line.
  2. Open each instance and set the axis coordinate to the corresponding weight.
  3. Set the weight class of the 900 instance to Black (the name already was "Black" but the weight class was "ExtraBold").

@sursly Does this sound sane to you? The result builds fine in current fontship (which under the hood is current fontmake and gftools) and the instances look even to me:

image

However since I don't understand what problem the uneven axis mappings were supposed to be fixing in the first place I may not actually be qualified to say this is the way to go.

@sursly
Copy link
Contributor

sursly commented Oct 28, 2020

Yeah this is solid. It looks good to me and I think is working fine. I have a preference for interpolation values to not be exactly on the 100s for lighter weights, but I know that is a personal visual thing, not a practical one – especially in a variable font.

@sursly sursly merged commit a17c327 into master Oct 28, 2020
@sursly sursly deleted the reset-axis-in-glyphs branch October 28, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weight axis issue building with new gftools
2 participants