Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Setting Value of Group-Object with Sending Changed Converted Value Only #258

Closed

Conversation

cornelius-koepp
Copy link
Contributor

Will check based on changed value after conversion.

Calling valueModifiedSend(value, type) with different values will only send, if value represented in given dpt is not the same.

@thelsing
Copy link
Owner

thelsing commented Sep 8, 2023

Is there any reason that you marked this PR as draft? Do you still want to change something?

Copy link
Contributor

@mumpf mumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion the forceSend argument should not be there, because there is already the value method, which clearly sends a value.

But if you add forceSend, it should be handled together with Uninitialized.

src/knx/group_object.cpp Show resolved Hide resolved
src/knx/group_object.cpp Outdated Show resolved Hide resolved
@cornelius-koepp
Copy link
Contributor Author

because there is already the value method, which clearly sends a value.

The value(..)-method should be preferred when the knowlege of object value changed is not relevant.

forceSend [...] should be handled together with Uninitialized.

By handling the same way as Uninitialized, there would be no feeback of object value change and no advantage in comparison to value(..).

@cornelius-koepp
Copy link
Contributor Author

Is there any reason that you marked this PR as draft? Do you still want to change something?

Yes, the 'draft' state was intended, to have the room for optimizations, feedback (for this hopefully generically usable extension of public group-object-api) and further testing. Optimization and feedback seen yesterday.

@cornelius-koepp
Copy link
Contributor Author

Replaced by #272 with checking for update only.

@cornelius-koepp cornelius-koepp deleted the feature/send-value-modified-only branch April 28, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants