Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow persistent audio streaming over network #159

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jayfan0
Copy link
Contributor

@jayfan0 jayfan0 commented Aug 13, 2024

As per the Ingenic Audio-Daemon usage guide

This PR allows a persistent listener in the background to be loaded with IA daemon.

Also introduces an Audio settings interface on the webUI

@roleoroleo
Copy link
Contributor

If I understand properly this feature can be used to create a rtsp backchannel.
Is it correct?

@jayfan0 jayfan0 reopened this Aug 16, 2024
@jayfan0
Copy link
Contributor Author

jayfan0 commented Aug 16, 2024

If I understand properly this feature can be used to create a rtsp backchannel. Is it correct?

Im not sure about how the backend works tbh, probably a question for @gtxaspec as its on his repo. This PR just utilises the feature

@jayfan0 jayfan0 marked this pull request as draft August 16, 2024 21:13
@jayfan0 jayfan0 marked this pull request as ready for review August 16, 2024 21:49
Copy link
Owner

@themactep themactep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove indents in the html part of the page for smaller size and more compact file.

package/thingino-webui/files/var/www/x/config-audio.cgi Outdated Show resolved Hide resolved
package/thingino-webui/files/var/www/x/config-audio.cgi Outdated Show resolved Hide resolved
package/thingino-webui/files/var/www/x/config-audio.cgi Outdated Show resolved Hide resolved
package/thingino-webui/files/var/www/x/config-audio.cgi Outdated Show resolved Hide resolved
@themactep
Copy link
Owner

Is there a reason we want to keep it in the iad daemon controller? Maybe extract it to a separate file and employ rc.common derectives for starting/stopping the daemon?

@jayfan0
Copy link
Contributor Author

jayfan0 commented Aug 16, 2024

2 reasons really

  1. It seems like it was dependent on iad so made sense to have it as an extension of it
  2. Netcat doesnt like to be run as a daemon... not with start-stop-daemon anyway so i had to start and stop it this way. Will likely have to do the same with separate file too

@gtxaspec gtxaspec force-pushed the master branch 9 times, most recently from 3b04d8e to bed59ab Compare November 21, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants