Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tmw-branded help #230

Closed
wants to merge 1 commit into from
Closed

Conversation

Helianthella
Copy link
Member

to-do:

  • finish gm commands
  • add licence page
  • add sources to about-server

@Helianthella
Copy link
Member Author

about the "tips" folder.. it needs a serious cleanup; will do this tonight or tomorrow

@wushin wushin added the test label Jan 30, 2015
@@ -0,0 +1,22 @@
<- @@index|<<Back to Index>>@@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not exist, instead rely on the overlayed one from manaplus itself

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the one from manaplus also includes copyright for tmw and some links do now work; I want that page to be only about manaplus, not manaplus+tmw+evol

@4144
Copy link
Contributor

4144 commented Jan 30, 2015

Override existing files is not good.
For local server help exists page "about-server" and for tmw also "about-tmw"

@Helianthella
Copy link
Member Author

@4144 I overwrite the "about manaplus" page because it includes information about tmw and steals the description from tmw and because I moved the "powered by" there

and I overwrite index, header and footer because of your manaplus branding and because I need to add gmcommand

if I do not overwrite index, users have to go to "About Manaplus" > "Infos about the current server"

@4144
Copy link
Contributor

4144 commented Jan 30, 2015

Most of changes can be patches to manaplus help

@wushin wushin modified the milestone: v2015.2.3 Jan 30, 2015
@wushin
Copy link
Member

wushin commented Jan 30, 2015

IMO, anything in client data should have the ability to be overwritten, but also we should give credit to 4144 with Manaplus. @4144 Is it possible we can come up collectively with a better "about" section that includes both, possibly all the server infos? @mekolat @o11c @Cassy1

@4144
Copy link
Contributor

4144 commented Jan 31, 2015

@wushin yes

@Helianthella
Copy link
Member Author

ok then I will remove "about.txt", remove "about tmw" from index and rename "about manaplus" to just "about" 💩

@wushin
Copy link
Member

wushin commented Feb 1, 2015

@mekolat don't forget to update make updates script.

@Helianthella
Copy link
Member Author

so @o11c what do I do? I continue to write the commands by hand or I wait for you to make tmwa generate from atcommand_local ?

@Helianthella
Copy link
Member Author

@wushin wushin removed the test label Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants