Fix: Conditional roles #59
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
python_a2alibrary to improve flexibility and compatibility in handling function roles and API keys for OpenAI and Ollama integrations. The changes primarily focus on adding configurable function roles and API key support, ensuring better customization and adaptability for different use cases.Enhancements to API Key Handling:
python_a2a/client/llm/ollama.py: Made theapi_keyparameter configurable instead of hardcoding it to "ollama" in bothclientandasync_clientinitialization. [1] [2]python_a2a/server/llm/ollama.py: Similarly updated theapi_keyparameter to be configurable forclientandasync_client. [1] [2]Improvements to Function Role Configuration:
python_a2a/client/llm/openai.py: Introduced thefunction_roleattribute with a default value of "function" and replaced hardcoded function roles in methods such assend_messageandsend_conversation. [1] [2] [3] [4]python_a2a/server/llm/openai.py: Added thefunction_roleattribute and updated function role handling in methods likehandle_messageandhandle_conversation. [1] [2] [3] [4]python_a2a/client/llm/ollama.pyandpython_a2a/server/llm/ollama.py: Setfunction_roleto "tool" for Ollama-specific integrations. [1] [2]Associations
This PR should /close issue #53