Skip to content

Conversation

@bryantam
Copy link

@bryantam bryantam commented Mar 6, 2018

by comparing pointers to fltSemantics, and convert them to double/float

comparing pointers to fltSemantics
@bryantam bryantam requested review from aoli-al and mmroz March 6, 2018 18:55
Copy link

@aoli-al aoli-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to use convertToDouble and convertToFloat to avoid converting APFloat manually.

Copy link

@aoli-al aoli-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantam bryantam merged commit eb862aa into themaplelab:wala-feature/FloatLiterals Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants