Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude selector option to ignore some changes #241

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Add exclude selector option to ignore some changes #241

merged 2 commits into from
Feb 28, 2019

Conversation

kevinschaul
Copy link
Contributor

  • Add exclude_selector to Page
  • Adjust Page.match_text and PageSnapshot.match_text to use exclude_selector
  • Expose exclude_selector in relevant views
  • Tests
  • Documentation

Fixes #239

@kevinschaul
Add exclude selector option to ignore some changes
cbba7ce 
- Add exclude_selector to Page
- Adjust Page.match_text and PageSnapshot.match_text to use exclude_selector
- Expose exclude_selector in relevant views
- Tests
- Documentation

Fixes themarshallproject#239
GabeIsman
GabeIsman requested changes Feb 27, 2019
View reviewed changes
Copy link
Member

@GabeIsman GabeIsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Kevin,

This looks fantastic. Thanks for taking the time to put this together. I noted one small thing that looks like a copy-paste error. Once that's fixed, this should be good to merge.

app/models/page_snapshot.rb Outdated Show resolved Hide resolved
@GabeIsman
Copy link
Member

Great! Thanks for fixing.

@GabeIsman GabeIsman merged commit 107da2d into themarshallproject:develop Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabeIsman GabeIsman GabeIsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinschaul @GabeIsman