Skip to content

Pull Requests Submission and Review

Guo Liu edited this page Jul 28, 2020 · 1 revision

Pull Requests Submission

Currently repos have read permissions, so contributors can create pull request from a fork, using develop branch as base.

Pull requests should include proper documentation, comments, unit test, code format and commit message format. Repos should already have Prettier, Commitizen and Jest set up.

Pull Requests Review

Pull requests on this repo should be reviewed by at least one member of staff team. On other repos, pull requests should be reviewed at least one member of dev team. For changes on frontend analytic events and backend database migration, one member of data team is also required for review.