Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I not load velocity.min.js and velocity.ui.min.js? #202

Closed
5 of 11 tasks
webees opened this issue Mar 26, 2018 · 4 comments
Closed
5 of 11 tasks

Can I not load velocity.min.js and velocity.ui.min.js? #202

webees opened this issue Mar 26, 2018 · 4 comments

Comments

@webees
Copy link

webees commented Mar 26, 2018

I agree and want to create new issue


Expected behavior

After all animations are disabled, velocity.min.js and velocity.ui.min.js should not be loaded.

(Partial animation can be done through jquery.js. Instead of relying on velocity.js.)

Actual behavior

Utils.js and motion.js have dependency on velocity.js. It seems that some animations cannot be closed by configuration.

Steps to reproduce the behavior

  1. motion 》》enable: false

Hexo Information

Hexo version

hexo: 3.6.0
hexo-cli: 1.1.0
os: Windows_NT 10.0.16299 win32 ia32
http_parser: 2.7.0
node: 8.7.0
v8: 6.1.534.42
uv: 1.15.0
zlib: 1.2.11
ares: 1.10.1-DEV
modules: 57
nghttp2: 1.25.0
openssl: 1.0.2l
icu: 59.1
unicode: 9.0
cldr: 31.0.1
tz: 2017b

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

motion:
  enable: false
@sli1989
Copy link
Collaborator

sli1989 commented Mar 27, 2018

The PR #113 has discussed about the issue. Waiting for optimization.

@webees
Copy link
Author

webees commented Mar 28, 2018

good job!

@stale
Copy link

stale bot commented Jun 8, 2018

This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jun 8, 2018
@stale stale bot closed this as completed Jun 15, 2018
@theme-next theme-next locked as resolved and limited conversation to collaborators Apr 1, 2019
@stevenjoezhang
Copy link
Contributor

Fixed in #951

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants