Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load velocity only if motion is enabled #113

Closed
wants to merge 1 commit into from
Closed

Load velocity only if motion is enabled #113

wants to merge 1 commit into from

Conversation

maple3142
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

velocity is added in site even if motion.enable is false

Issue Number(s): N/A

What is the new behavior?

velocity only added if motion.enable is true

How to use?

No need to change anything.

Does this PR introduce a breaking change?

  • Yes.
  • No.

@tsanie
Copy link
Contributor

tsanie commented Feb 4, 2018

There is a problem, that the sidebar in Must/Mist is now hard-code dependent on the velocity. So need to refactor the motion.js first...

@maple3142
Copy link
Contributor Author

Or change it to another option?
Like disable_velocity, and warn user about Must/Mist theme and motion depends on velocity.

@ivan-nginx
Copy link
Member

ivan-nginx commented Feb 4, 2018

No. i think no need to add extra options here, but about warn to Mist/Muse nice idea.
And as Tsanie talk above, need to refactor this somehow. To external repo maybe.

So, this will be merged? Let's wait another maintainers vision about this.

@wafer-li
Copy link
Member

wafer-li commented Feb 4, 2018

That is similar to the "turn off js" problem.

agree with @ivan-nginx
I think showing the warning is enough.

@sli1989
Copy link
Collaborator

sli1989 commented Mar 27, 2018

So, add annotation in _config.yml?

Copy link
Member

@geekrainy geekrainy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be confirmed

@geekrainy
Copy link
Member

Caused by click button did not respond.

$('body').velocity('scroll');

@ivan-nginx ivan-nginx changed the title load velocity only if motion is enabled Load velocity only if motion is enabled Dec 16, 2018
@ivan-nginx ivan-nginx mentioned this pull request Jan 30, 2019
72 tasks
@1v9 1v9 changed the title Load velocity only if motion is enabled WIP: Load velocity only if motion is enabled Mar 30, 2019
@1v9 1v9 changed the title WIP: Load velocity only if motion is enabled Load velocity only if motion is enabled Mar 30, 2019
@ivan-nginx ivan-nginx closed this Apr 2, 2019
@stevenjoezhang
Copy link
Contributor

Superseded by #951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants