-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load velocity only if motion is enabled #113
Conversation
There is a problem, that the sidebar in Must/Mist is now hard-code dependent on the velocity. So need to refactor the |
Or change it to another option? |
No. i think no need to add extra options here, but about warn to Mist/Muse nice idea. So, this will be merged? Let's wait another maintainers vision about this. |
That is similar to the "turn off js" problem. agree with @ivan-nginx |
So, add annotation in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be confirmed
Caused by click button did not respond. hexo-theme-next/source/js/src/utils.js Line 113 in ca2554b
|
Superseded by #951 |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
velocity
is added in site even ifmotion.enable
is falseIssue Number(s): N/A
What is the new behavior?
velocity
only added ifmotion.enable
is trueHow to use?
No need to change anything.
Does this PR introduce a breaking change?