Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About theme-next-han #911

Closed
stevenjoezhang opened this issue Jun 11, 2019 · 4 comments
Closed

About theme-next-han #911

stevenjoezhang opened this issue Jun 11, 2019 · 4 comments

Comments

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Jun 11, 2019

Han,即「漢字標準格式」 印刷品般的漢字排版框架。( https://github.com/ethantw/Han

该框架在 iissnan/hexo-theme-next#1598 中被集成到NexT。不过值得注意的是,这只包含了css部分,而没有js部分。也就是说,它只产生了两个效果:

  • 调整了一些margin、padding,以及blockquote等tag的样式
  • 设置了中文的字体

对于第一条,Han对NexT原本样式的影响不小: iissnan/hexo-theme-next#1645 ,事实上已经做出了一些妥协: https://github.com/iissnan/hexo-theme-next/blob/master/source/css/_common/components/third-party/han.styl
对于第二条,中文字体已经可以方便的通过_config.yml中的font定义。

另外,Han已经失去维护(上一个release已经是在4年之前)。

综上所述,从某种意义上讲,theme-next-han所导致的问题已经超出了Han所带来的正面效果——它并不适合NexT这种包含大量既定样式的主题。

是否需要考虑将其移除?


@welcome
Copy link

welcome bot commented Jun 11, 2019

Thanks for opening this issue, maintainers will get back to you as soon as possible!

@1v9 1v9 pinned this issue Jun 11, 2019
@1v9
Copy link
Member

1v9 commented Jun 11, 2019

Also see #910 & #800.

1v9 added a commit that referenced this issue Jun 11, 2019
@1v9 1v9 mentioned this issue Jun 11, 2019
@polls polls bot added the 📊 Polls label Jun 11, 2019
@jiangtj
Copy link
Member

jiangtj commented Jun 12, 2019

ethantw仍然在合并PR, 所以可以认为仍在维护. 但我支持移除.


ethantw is still merging PR, so it is still maintained. But I support remove.

@jiangtj
Copy link
Member

jiangtj commented Jun 12, 2019

Or consider integrating in a non-destructive way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants