Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console reminder if new version released #1002

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Console reminder if new version released #1002

merged 3 commits into from
Jul 24, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 23, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
@theme-next theme-next deleted a comment Jul 23, 2019
1v9
1v9 reviewed Jul 23, 2019
View reviewed changes
scripts/tags/caniuse.js Outdated Show resolved Hide resolved
1v9
1v9 reviewed Jul 23, 2019
View reviewed changes
scripts/merge-configs.js Outdated Show resolved Hide resolved
@stevenjoezhang stevenjoezhang changed the title Console reminder if new version released Console reminder if new version released & code style update Jul 24, 2019
@stevenjoezhang stevenjoezhang marked this pull request as ready for review July 24, 2019 02:37
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 24, 2019
@stevenjoezhang stevenjoezhang requested review from jiangtj and 1v9 July 24, 2019 02:38
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@stevenjoezhang stevenjoezhang changed the title Console reminder if new version released & code style update Console reminder if new version released Jul 24, 2019
jiangtj
jiangtj reviewed Jul 24, 2019
View reviewed changes
scripts/merge-configs.js Outdated Show resolved Hide resolved
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@stevenjoezhang stevenjoezhang requested a review from jiangtj July 24, 2019 03:14
@stevenjoezhang stevenjoezhang merged commit 1f0fcfe into master Jul 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the warning branch July 24, 2019 05:29
@1v9
Copy link
Member

1v9 commented Jul 25, 2019 •
edited
Loading

Docs not added.

@ivan-nginx ivan-nginx mentioned this pull request Aug 1, 2019
Closed
33 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Console reminder if new version released (theme-next#1002)
6f6cfb9
@stevenjoezhang
Copy link
Contributor Author

In fact, I misunderstood ivan's idea: #318 (comment)
Console reminder should be designed for the NexT plug-in rather than NexT itself. Maybe this feature will be removed in the future.

stevenjoezhang added a commit to next-theme/hexo-theme-next that referenced this pull request Jul 3, 2020
@stevenjoezhang
Remove console reminder
533fea7 
* Revert theme-next/hexo-theme-next#343

* Revert theme-next/hexo-theme-next#1002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangtj jiangtj jiangtj approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

@1v9 1v9 Awaiting requested review from 1v9

Assignees
No one assigned
Labels
🌟 New Feature 🎯 Roadmap
Projects
None yet
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjoezhang @1v9 @jiangtj