Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor save_scroll #1049

Merged
merged 4 commits into from
Aug 3, 2019
Merged

Refactor save_scroll #1049

merged 4 commits into from
Aug 3, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 added this to the v7.4.0 milestone Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@stevenjoezhang stevenjoezhang merged commit 97ec251 into master Aug 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the cookie branch August 3, 2019 12:30
1v9 added a commit that referenced this pull request Aug 3, 2019
@1v9
Remove unneeded save_scroll of minify
146bac4 
#1049
@stevenjoezhang stevenjoezhang mentioned this pull request Aug 17, 2019
Merged
15 tasks
@stevenjoezhang
Copy link
Contributor Author

Superseded by #1106

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Refactor save_scroll (theme-next#1049)
50d86ad
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9
Remove unneeded save_scroll of minify
a1313eb 
theme-next#1049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
🛠 Improvement ⏱ Performance Skip Release
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjoezhang @1v9