Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove full-image tag #1053

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Remove full-image tag #1053

merged 1 commit into from
Aug 4, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor Author

References:
5a70fd3
08eb90e
#52
iissnan/hexo-theme-next#1911

@1v9 1v9 added this to the v7.4.0 milestone Aug 3, 2019
@1v9 1v9 added the ⭐ Feature label Aug 3, 2019
@1v9 1v9 merged commit 1139572 into master Aug 4, 2019
1v9 added a commit to theme-next/theme-next.org that referenced this pull request Aug 4, 2019
@ivan-nginx
Copy link
Member

  1. It's actually no Feature, but BC.
  2. How about Lazy loading Image?
  3. How about refactoring FI into something about that?

I don't understand why in so little period so many removes & refactoring.

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Aug 5, 2019

About Lazy loading Image, just enable lazyload in _config.yml. See: #957

There is no sidebar affix in the legacy version of NexT: https://notes.iissnan.com/, so full-image / wide-image is a nice feature. As for now, I recommend that users use mediumzoom to achieve similar results.

IIssNan's Notes
胡编一通,乱写一气

@ivan-nginx
Copy link
Member

ivan-nginx commented Aug 5, 2019

About Lazy loading Image, just enable lazyload in _config.yml. See: #957

Yea, but with this option lazyloaded will be all images. With tag it can be single. Or not can be.


mediumzoom it's like fancybox (need to click on picture). I'm talking about wideimage, like in tranquilpeack site.

@stevenjoezhang
Copy link
Contributor Author

The main problem is that the style in v7.x has changed a lot compared to v5.x
.post-block has a padding of 40px which makes it impossible to control the width of full image

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
chanw9 pushed a commit to chanw9/hexo-theme-next that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants