Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color option for bookmark #1112

Merged
merged 7 commits into from
Aug 20, 2019
Merged

Add color option for bookmark #1112

merged 7 commits into from
Aug 20, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Aug 19, 2019

No description provided.

@1v9 1v9 added this to the v7.4.0 milestone Aug 19, 2019
@stevenjoezhang
Copy link
Contributor

Which one is better?

color: FFF
#or
color: "#FFF"

hexo-theme-next/_config.yml

Lines 370 to 371 in c970d79

start: "#ccc" # Start color (hex, rgba, hsla or color keywords)
end: "#111" # End color (hex, rgba, hsla or color keywords)

color: fc6423

@1v9
Copy link
Member Author

1v9 commented Aug 19, 2019

rating.color is not belong to stylus.

color: "#8a2be2" # hex
color: blueviolet # html
color: rgb(138, 43, 226) # rgb
color: hsl(271, 76%, 53%) # hsl

Exclude hex value, other colors could be single or double quoted.

@1v9 1v9 added the CSS label Aug 19, 2019
@1v9
Copy link
Member Author

1v9 commented Aug 19, 2019

Copy link
Contributor

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1v9 Revert your last commit, the same job was done in #1113

@1v9 1v9 merged commit 5d051ca into master Aug 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the right branch August 20, 2019 05:25
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants