Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand beian options for users in mainland China #1121

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Expand beian options for users in mainland China #1121

merged 4 commits into from
Aug 23, 2019

Conversation

InterHorse
Copy link
Contributor

@InterHorse InterHorse commented Aug 23, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

No feature of the public security record.

Issue resolved: N/A

What is the new behavior?

For Chinese users, except for the ICP record, they need public security record, too. I added this feature in this pull request.

How to use?

In NexT _config.yml:

footer:
  beian:
    enable: true
    icp: 京ICP备19031359号-2
    gongan_id: 11010502038639
    gongan_num: 京公网安备 11010502038639号
    gongan_icon_url: /uploads/beian.png

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Aug 23, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2019

CLA assistant check
All committers have signed the CLA.

@InterHorse InterHorse closed this Aug 23, 2019
@InterHorse InterHorse reopened this Aug 23, 2019
@1v9
Copy link
Member

1v9 commented Aug 23, 2019

原有的备案选项扩充即可,不用新增选项。

@InterHorse
Copy link
Contributor Author

原有的备案选项扩充即可,不用新增选项。

It has been modified.

_config.yml Outdated Show resolved Hide resolved
_config.yml Outdated Show resolved Hide resolved
@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Aug 23, 2019

需要在这里更新一下文档:https://github.com/theme-next/theme-next.org/pulls

GitHub
The website for NexT theme. Contribute to theme-next/theme-next.org development by creating an account on GitHub.

@1v9 1v9 changed the title Feat: Add the feature of gonganbeian for Chinese users Expand beian options for users in mainland China Aug 23, 2019
@InterHorse
Copy link
Contributor Author

InterHorse commented Aug 23, 2019

需要在这里更新一下文档:https://github.com/theme-next/theme-next.org/pulls

GitHub**theme-next/theme-next.org**The website for NexT theme. Contribute to theme-next/theme-next.org development by creating an account on GitHub.

请问文档需要改什么地方?

GitHub
The website for NexT theme. Contribute to theme-next/theme-next.org development by creating an account on GitHub.

@InterHorse
Copy link
Contributor Author

InterHorse commented Aug 23, 2019

需要在这里更新一下文档:https://github.com/theme-next/theme-next.org/pulls

GitHub**theme-next/theme-next.org**The website for NexT theme. Contribute to theme-next/theme-next.org development by creating an account on GitHub.

目前文档中好像没有关于大陆用户备案的使用说明。
https://theme-next.org/docs/theme-settings/footer
应该在这个文档里,但是目前没有。 @stevenjoezhang

@1v9
Copy link
Member

1v9 commented Aug 23, 2019

你可以补上

@1v9 1v9 added this to the v7.4.0 milestone Aug 23, 2019
@1v9
Copy link
Member

1v9 commented Aug 23, 2019

照着 Site Copyright Name 简单陈述即可。

@InterHorse
Copy link
Contributor Author

照着 Site Copyright Name 简单陈述即可。

@1v9 已补

@1v9 1v9 merged commit 0d1454b into theme-next:master Aug 23, 2019
@welcome
Copy link

welcome bot commented Aug 23, 2019

Congrats on merging your first pull request here! 🎉 How awesome!

@1v9
Copy link
Member

1v9 commented Aug 23, 2019

@all-contributors please add @MartinMa94 for code, doc

@allcontributors
Copy link
Contributor

@1v9

I've put up a pull request to add @MartinMa94! 🎉

@InterHorse InterHorse deleted the gonganbeian branch August 24, 2019 05:30
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants