Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order for theme_inject #1136

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Add order for theme_inject #1136

merged 1 commit into from
Aug 28, 2019

Conversation

jiangtj
Copy link
Member

@jiangtj jiangtj commented Aug 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Order of theme_inject is only determined by the priority of the injection.

What is the new behavior?

Order of theme_inject is determined by the priority of the injection or special configuration in inject api.

Does this PR introduce a breaking change?

  • Yes.
  • No.

Redesigned the sequential configuration of the multi-comment system.

# Multiple Comment System Support
comments:
  # Available values: tabs | buttons
  style: tabs
  # Choose a comment system to be displayed by default.
  # Available values: changyan | disqus | disqusjs | facebook_comments_plugin | gitalk | livere | valine | vkontakte
  active:
  # Setting `true` means remembering the comment system selected by the visitor.
  storage: true
  # Modify texts or order for any navs, here are some examples.
  nav:
-    #disqus: disqus
-    #facebook_comments_plugin: <i class="fa fa-facebook-official" aria-hidden="true"></i> facebook
-    #gitalk: Load Gitalk
+    #disqus:
+    #  text: Load Disqus
+    #  order: -1
+    #facebook_comments_plugin:
+    #  text: <i class="fa fa-facebook-official" aria-hidden="true"></i> facebook
+    #gitalk:
+    #  order: -2

@1v9 1v9 removed the ⭐ Feature label Aug 27, 2019
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u provide previous BC configuration? Like in other BC pulls.

@jiangtj
Copy link
Member Author

jiangtj commented Aug 27, 2019

Can u provide previous BC configuration? Like in other BC pulls.

Okay, done.

@jiangtj jiangtj merged commit eb01dc5 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the inject-order branch August 28, 2019 01:02
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants