-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fancybox & medium-zoom for hexo asset_img tag #1166
Conversation
Thanks so much for opening your first PR here! |
Can you test whether <img> under <a> label is also managed by mediumzoom ? Some users expect the link to work. |
And you can also fix fancybox in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, in the stylesheet of theme-next, .post-body > p > img
is different from .post-body > img
(with a margin of 20px)
Thus a better solution is to ask Hexo to fix the bug of asset_image tag: <img>
should always be wrapped with <p>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be no more elegant solution
Congrats on merging your first pull request here! 🎉 How awesome! |
@all-contributors please add @sankoshine for bug |
I've put up a pull request to add @sankoshine! 🎉 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
If I use hexo tag plugins to insert an image, it will not be rendered as medium zoom style.
i.e.
{% asset_img 2222.jpg %}
What is the new behavior?
Medium zoom take effects on images whether imported with hexo
asset_img
tag or markdown-style![](image.jpg)
.How to use?
Just set true.
In NexT
_config.yml
:Does this PR introduce a breaking change?