Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valine & disqus meta for #1305 #1351

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Conversation

sli1989
Copy link
Collaborator

@sli1989 sli1989 commented Jan 14, 2020

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor

disqus also need to be modified

<a title="disqus" href="{{ url_for(post.path) }}#comments" itemprop="discussionUrl">

@jiangtj
Copy link
Member

jiangtj commented Jan 15, 2020

@sli1989 I saw the doc https://valine.js.org/visitor.html , but its configuration is not the same as in next. Can you try using the configuration in the documentation?

A fast, simple & powerful comment system.

@sli1989
Copy link
Collaborator Author

sli1989 commented Jan 15, 2020

I am fused about detailed programming stuffs.
For now, it works fine and intergrated in Next.
#345 was pulled by @xCss. u may ask him for this.

@stevenjoezhang
Copy link
Contributor

Looks like there is no problem with valine, I think this PR can be merged

@stevenjoezhang stevenjoezhang added this to the 7.7.1 milestone Jan 19, 2020
@stevenjoezhang stevenjoezhang changed the title Fix valine meta for #1305 Fix valine & disqus meta for #1305 Jan 22, 2020
@stevenjoezhang stevenjoezhang merged commit 8aa5b29 into theme-next:master Jan 22, 2020
@sli1989 sli1989 deleted the valine branch February 9, 2020 07:22
voidking pushed a commit to voidking/hexo-theme-next-2021 that referenced this pull request Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants