Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark styles of buttons #1409

Merged
merged 5 commits into from
Mar 15, 2020
Merged

Conversation

backrunner
Copy link
Contributor

@backrunner backrunner commented Mar 12, 2020

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build & CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

In current released version, when dark mode and scheme Pisces or Gemini is enabled, the button in post-expand is still using the default styles:

image

I made a set of dark styles for these buttons:

image

hover:
image

  • Link to demo site with this changes: N/A

@backrunner backrunner changed the title Fix dark mode styles of .btn (Pisces & Gemini) Fix dark styles of .btn (Pisces & Gemini) Mar 12, 2020
@stevenjoezhang
Copy link
Contributor

Is it possible to move all dark mode related changes into source/css/_colors.styl?
Thanks!

@backrunner
Copy link
Contributor Author

Is it possible to move all dark mode related changes into source/css/_colors.styl?
Thanks!

Done, styles seems working fine, but more test may be required.

@stevenjoezhang stevenjoezhang added this to the 7.8.0 milestone Mar 12, 2020
@backrunner backrunner changed the title Fix dark styles of .btn (Pisces & Gemini) Fix dark styles of buttons Mar 12, 2020
@stevenjoezhang stevenjoezhang self-requested a review March 13, 2020 15:14
@stevenjoezhang stevenjoezhang merged commit 4d7636a into theme-next:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants