-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix svg confict in algolia vender #173
Conversation
Tested on all schemes? Please, attach screens with tests in all schemes (4 screens). |
I find a strange phenomenon. With or without the above bugfix using CDN,
|
Try to disable sidebar, bug still exists? |
All scheme with local lib or vender CDN, the bug is still exist. Need further investment. |
@sli1989 reproduce steps, please. I'll join this pull as remote and trying to test. |
|
U test on your domen or u have any subdomen(s) for tests? If yes, can i see live demo with this? P.S. I'm just not use Algolia and need to register this under new test domen|subdomain: |
I haven't push them to the blog, I would do it if i failed to find the bug. I am trying to test on V604. |
@sli1989 can u create subdomain for tests, something like |
Deployed for now in http://saili.science/ |
So, |
Just leave the |
No need to do this. Need just to disable I see this config for now as default: algolia_search:
enable: false
hits:
per_page: 10
labels:
input_placeholder: Search for Posts
hits_empty: "We didn't find any results for the search: ${query}"
hits_stats: "${hits} results found in ${time} ms"
# Local search
# Dependencies: https://github.com/theme-next/hexo-generator-searchdb
local_search:
enable: true But if u want to use Algolia search instead of Local search (u no need 2 search boxes at once, right?), i think need to disable local search: algolia_search:
enable: true
hits:
per_page: 10
labels:
input_placeholder: Search for Posts
hits_empty: "We didn't find any results for the search: ${query}"
hits_stats: "${hits} results found in ${time} ms"
# Local search
# Dependencies: https://github.com/theme-next/hexo-generator-searchdb
local_search:
enable: false Try it. |
emm. i haven't update the repo. I did all like this. I forgot the |
So, u talking about what it's clean repo, right? But in your source code (view-source:http://saili.science/) i see source of |
Yes, you are right. Solved, but the search box can be closed only with clicking the close button instead of clicking outside of the area. |
So, bug was in both Algolia and Local searches enabled? I think need to add console warning or something like this on this situation.
And this was added only for Local search in this pull. In Algolia search this closed by outside type wasn't added. But, anyone can add it, if he want. 😄 Initially, local search was created and modified by @flashlab and then was greatest modifications from @uchuhimo. |
I have no svg-related plugin to run test. Just perform same as before to avoid display redundant element when using CDN vendor. Need screenshots? |
No need screenshots. Just explain what's not work for now? |
ADDED IN PR CONTENT. |
«Update branch», «Squash and merge». |
* Fix svg confict in algolia vender
In former file, all svg-related element in blog would be blocked leading to the conflict between algolia and svgs. Related issue.
In this PR, more exact element are found and blocked using algolia CDN , in this way, other svg-related element can be display usually. More related issues about the missing of SVG can be solved.