-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment count in mobile #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other schemes?
recommend to add switch in _config.yml post meta |
I still can't understand why it was added to disabled by default? Trafic economy or what? What's the reason? |
dont know either |
All tested. The screenshots are added. |
I think it's a necessary meta. |
Comments system? All tested? Again: need to try why it was added to disabled by default? Here is history, but i still no found any arguments on this addition (hide in mobile). Ok, test it on other possible popular comments system and i think we can merge it. Strange situation. |
OK, more comment systems would be tested. |
Gitment comment system works fine. The comment count display with Disqus in homepage but not in post page. Check this demo. |
Disqus appear not instantly at most time and for now i see comments count in homepage and in post page too. So, i think it's fine. |
OK, I doesn't use disqus. It seems all fine. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The comment count in mobile doesn't display. It's a necessary meta, so display it without a enable option.
Issue Number(s): #180
What is the new behavior?
Add the count meta in post.
before

after
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?