hide single post or posts in specific categories on the home page #385

seven-steven · 2018-08-11T07:16:57Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Hide single post or posts in specific categories on the home page.

Issue Number(s): #385

What is the new behavior?

Hide single post or posts in specific categories on the home page.

Screens with this changes:

emmmmmmm......
I think screens can't show this feature well, what I did is just hide some posts on the home page.
Link to demo site with this changes: Seven's blog

How to use?

In NexT _config.yml:

# Hide single post or posts in specific categories on the home page
#  If `hide_post` is `true`, you need to add `hide: true` in your post which you want to hide on the home page.
#  If you enabled the item `hide_categories`, you need just list the categories which you want to hide on the home page under the item `categories`.
hide:
  hide_post: false
  hide_categories:
    enable: false
    categories:
#     - categorie1
#     - categorie2

Does this PR introduce a breaking change?

Yes.
No.

seven-steven · 2018-08-11T08:44:36Z

Here is a document of how to use this feature. Document

ivan-nginx · 2018-08-11T09:19:19Z

@seven-steven can u add docs in English?

seven-steven · 2018-08-11T10:28:33Z

@ivan-nginx
emmmm..... So embarrassed, I just don't know where to add the docs in.
Should I write the docs in _config.yml or somewhere else?

seven-steven · 2018-08-11T10:29:17Z

@ivan-nginx
I think it's better to add some comments in the _config.yml .

like this:

# Hide single post or posts in specific categories on the home page
#  If `hide_post` is `true`, you need to add `hide: true` in your post which you want to hide on the home page.
#  If you enabled the item `hide_categories`, you need just list the categories which you want to hide on the home page under the item `categories`.
hide:
  hide_post: false
  hide_categories:
    enable: false
    categories:
#     - categorie1
#     - categorie2

And my English is not very good actually, so is there anythig wrong in my comments?

ivan-nginx · 2018-08-11T10:39:00Z

I think it's better to add some comments in the _config.yml .

Yeah, pretty nice!

seven-steven · 2018-08-11T10:56:05Z

@ivan-nginx
Thanks a lot for your affirmation.

ivan-nginx · 2018-08-31T10:01:34Z

Need to check it for speed. With many posts. It's index file and i think will slowing down during generate site with ~500 posts or more. Please, need to test it.

seven-steven · 2018-09-02T14:09:53Z

I'll try to make it better, thanks for your advice.

stevenjoezhang · 2018-12-18T03:17:57Z

Any progress you've already made? I'm happy to help with this issue.

stevenjoezhang · 2018-12-26T06:55:45Z

@seven-steven Another problem, the changes in layout/index.swig will not only affect the home page.

seven-steven · 2018-12-27T01:11:31Z

@seven-steven Another problem, the changes in layout/index.swig will not only affect the home page.

emmmm... that's all what I want todo. Do you have other ideas?

stevenjoezhang · 2018-12-27T05:29:38Z

@seven-steven Use page.current === 1. In index.swig:

{% extends '_layout.swig' %}
{% import '_macro/post.swig' as post_template %}
{% import '_macro/sidebar.swig' as sidebar_template %}

{% block title %}{{ title }}{% if theme.index_with_subtitle and subtitle %} – {{ subtitle }}{% endif %}{% endblock %}

{% block page_class %}
  {% if is_home() %}page-home{% endif -%}
{% endblock %}

{% block content %}
  <section id="posts" class="posts-expand">
    {% for post in page.posts %}
      {% if is_home() && page.current === 1 %}
        {% set hide = false %}
        {% if theme.hide.hide_post && post.hide %}
          {% set hide = true %}
        {% elif theme.hide.hide_categories.enable %}
          {% for cat in post.categories %}
            {% if !hide %}
              {% for categorie in cat %}
                {% if !hide %}
                  {% for item in theme.hide.hide_categories.categories %}
                    {% if !hide && item == categorie %}
                      {% set hide = true %}
                    {% endif %}
                  {% endfor %}
                {% endif %}
              {% endfor %}
            {% endif %}
          {% endfor %}
        {% endif %}
        {% if !hide %}
          {{ post_template.render(post, true) }}
        {% endif %}
      {% else %}
        {{ post_template.render(post, true) }}
      {% endif %}
    {% endfor %}
  </section>

  {% include '_partials/pagination.swig' %}
{% endblock %}

{% block sidebar %}
  {{ sidebar_template.render(false) }}
{% endblock %}

And you can update _config.yml to the latest version, to resolve conflicts.

seven-steven · 2018-12-27T06:39:01Z

Need to check it for speed. With many posts. It's index file and i think will slowing down during generate site with ~500 posts or more. Please, need to test it.

Sorry for the delay.

I hava already made a test today under the environment below:

OS: Ubuntu 18.10
CPU: Intel® Core™ i5-4200U CPU @ 1.60GHz × 4 
RAM: 7.7 GiB
Hexo: 3.8.0
node: 8.11.4

I made 790 posts to run the test:

And the file size is 5.1Mb in total:

Before set the "hide" param, it took 2.9min to generate all the posts:

Then I enabled the setting "hide_post", and add a line "hide: true" for all the posts.
It took 1.9min to generate all the posts:

At last, I enabled the setting "hide_categories", and add a line "categories: hide" for all the posts.
It took 1.83 min to generate all the posts:

That's all, It seems that it can save a little time to generate posts by hide posts on the home page.

seven-steven · 2018-12-27T06:47:20Z

And I find a bug here, if you hide some posts on the home page by this PR, the pagination will still count the hiden posts in.

I's not serious for me(uaually, I need just hide a few posts), but I'm not sure if it will trouble others.

seven-steven · 2018-12-27T06:52:30Z

@stevenjoezhang
Brilliant! Thank's for your advice! I'll do it later.

ivan-nginx · 2018-12-27T13:24:42Z

@seven-steven how you think, it is better will be use hexo-generator-index2 or similar plugin for Hexo? It seems pagination must work fine with this plugin.

Another variant to fix pagination – add filter from this PR to pagination directly?

Anyway, for now we have problem with slow generation for many posts, which i will fix it today. And after this fix i'll check and compare your changes too.

seven-steven · 2018-12-27T14:20:15Z

@ivan-nginx
About this feature, I got an idea, searched for information, tried to realize the function and made this PR to share my achievement. I didn't know there's a plugin which can achieve the same function until now.
I viewed the plugin hexo-generator-index2 just now, and I think this plugin may be better than my way.
If necessary, I can make a compare between the plugin and this PR later.
Thanks very much for your reply.

ivan-nginx · 2018-12-27T17:09:55Z

@seven-steven same plugin can be created just under the NexT in this path:
https://github.com/theme-next/hexo-theme-next/tree/master/scripts

seven-steven · 2018-12-28T06:11:08Z

@ivan-nginx
I am doing the compare between the plugin "hexo-generator-index2" and this PR now. the version of Next is just the same as this repository.
There's 700 posts in my "_posts" directory:

using the default setting, it took 2.88 min to generate all the posts:
```
 INFO  1245 files generated in 2.88 min
```
using the plugin hexo-generator-index2, it took 2.92 min to generate all the posts:
```
 INFO  1245 files generated in 2.92 min
```
(I ran the generate command again, and it took 2.82min.)
then I changed the Next version to this PR, and hide the same categories as the plugin hexo-generator-index2, it took 2.92min:
```
 INFO  1245 files generated in 2.92 min
```
Only considering the speed, it seems that the plugin and the PR is just the same. About the paginate the plugin does perform better.

To be honest, I am neither familiar with the Complete architecture of next nor javascript language. To fix the paginate by script, I need some time to learn all these things. It could take a time, really sorry about this.

That's all. Thanks.

Issues: #539, #385.

stevenjoezhang · 2019-03-08T07:38:48Z

How about only hide posts with hide: option in front matter, not in specific categories?

ivan-nginx · 2019-03-08T07:40:24Z

Why it's needed, can u explain?

stevenjoezhang · 2019-03-08T07:46:45Z

Emm.. maybe a hexo plugin would be better. Speeding up the generating process is more important

ivan-nginx · 2019-03-08T10:27:56Z

maybe a hexo plugin would be better

Yes.
But anyway, this is not actually needed. User can create page, not post, with any custom settings inside.

ivan-nginx

BTW, here is generators what provide same functionality if needed:

hexo-generator-index2
hexo-index-anything
hexo-generator-index-plus

stevenjoezhang · 2019-03-29T04:44:56Z

@seven-steven Thanks for your contributing. I'll fork hexo-generator-index to implement this feature, and maybe also the post-sticky feature (#447).

Try this plugin: https://github.com/stevenjoezhang/hexo-generator-indexed
Run:

npm remove hexo-generator-index
npm install hexo-generator-indexed

seven-steven · 2019-04-02T02:17:01Z

@stevenjoezhang Thanks a lot.

CLAassistant · 2019-04-02T12:25:27Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

hide single post or posts in specific categories on the home page

3973d18

add some comments in '_config.yml' about how to use the item 'hide'

98696b7

seven-steven mentioned this pull request Aug 11, 2018

[Featrue] Hide single post or posts in specific categories on the home page. #384

Closed

15 tasks

sli1989 added the ⭐ Feature label Aug 21, 2018

ivan-nginx added the Need Review label Dec 26, 2018

seven-steven added 2 commits December 27, 2018 15:04

just hide post on the first page

cbb6baa

Merge branch 'master' of github.com:theme-next/hexo-theme-next

190ad28

stevenjoezhang approved these changes Dec 27, 2018

View reviewed changes

ivan-nginx added a commit that referenced this pull request Dec 28, 2018

Cache is not enough? Ok, let's cache sidebar, scripts and 3rd-party's.

bb5cfe6

Issues: #539, #385.

ivan-nginx mentioned this pull request Dec 28, 2018

Cache is not enough? Ok, let's cache sidebar, scripts and 3rd-party's. #545

Merged

stevenjoezhang force-pushed the master branch from 07f52f2 to bb5cfe6 Compare December 29, 2018 07:20

stevenjoezhang force-pushed the master branch from 666aa6e to e699386 Compare December 29, 2018 10:39

ivan-nginx removed the Need Review label Mar 3, 2019

stevenjoezhang self-requested a review March 8, 2019 07:39

ivan-nginx removed the ⭐ Feature label Mar 8, 2019

ivan-nginx requested changes Mar 8, 2019

View reviewed changes

stevenjoezhang closed this Mar 29, 2019

ivan-nginx added the Backlog label Mar 29, 2019

ivan-nginx reopened this Apr 2, 2019

stevenjoezhang closed this Apr 2, 2019

stevenjoezhang added Feature Request Solved 🌟 New Feature and removed Backlog Feature Request 🌟 New Feature Solved labels Jul 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hide single post or posts in specific categories on the home page #385

hide single post or posts in specific categories on the home page #385

seven-steven commented Aug 11, 2018 •

edited

Loading

seven-steven commented Aug 11, 2018

ivan-nginx commented Aug 11, 2018

seven-steven commented Aug 11, 2018

seven-steven commented Aug 11, 2018

ivan-nginx commented Aug 11, 2018 •

edited

Loading

seven-steven commented Aug 11, 2018

ivan-nginx commented Aug 31, 2018

seven-steven commented Sep 2, 2018

stevenjoezhang commented Dec 18, 2018

stevenjoezhang commented Dec 26, 2018

seven-steven commented Dec 27, 2018

stevenjoezhang commented Dec 27, 2018

seven-steven commented Dec 27, 2018

seven-steven commented Dec 27, 2018

seven-steven commented Dec 27, 2018

ivan-nginx commented Dec 27, 2018 •

edited

Loading

seven-steven commented Dec 27, 2018

ivan-nginx commented Dec 27, 2018

seven-steven commented Dec 28, 2018 •

edited

Loading

stevenjoezhang commented Mar 8, 2019 •

edited

Loading

ivan-nginx commented Mar 8, 2019

stevenjoezhang commented Mar 8, 2019

ivan-nginx commented Mar 8, 2019 •

edited

Loading

ivan-nginx left a comment

stevenjoezhang commented Mar 29, 2019 •

edited

Loading

seven-steven commented Apr 2, 2019

CLAassistant commented Apr 2, 2019

hide single post or posts in specific categories on the home page #385

hide single post or posts in specific categories on the home page #385

Conversation

seven-steven commented Aug 11, 2018 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

seven-steven commented Aug 11, 2018

ivan-nginx commented Aug 11, 2018

seven-steven commented Aug 11, 2018

seven-steven commented Aug 11, 2018

ivan-nginx commented Aug 11, 2018 • edited Loading

seven-steven commented Aug 11, 2018

ivan-nginx commented Aug 31, 2018

seven-steven commented Sep 2, 2018

stevenjoezhang commented Dec 18, 2018

stevenjoezhang commented Dec 26, 2018

seven-steven commented Dec 27, 2018

stevenjoezhang commented Dec 27, 2018

seven-steven commented Dec 27, 2018

seven-steven commented Dec 27, 2018

seven-steven commented Dec 27, 2018

ivan-nginx commented Dec 27, 2018 • edited Loading

seven-steven commented Dec 27, 2018

ivan-nginx commented Dec 27, 2018

seven-steven commented Dec 28, 2018 • edited Loading

stevenjoezhang commented Mar 8, 2019 • edited Loading

ivan-nginx commented Mar 8, 2019

stevenjoezhang commented Mar 8, 2019

ivan-nginx commented Mar 8, 2019 • edited Loading

ivan-nginx left a comment

Choose a reason for hiding this comment

stevenjoezhang commented Mar 29, 2019 • edited Loading

seven-steven commented Apr 2, 2019

CLAassistant commented Apr 2, 2019

seven-steven commented Aug 11, 2018 •

edited

Loading

ivan-nginx commented Aug 11, 2018 •

edited

Loading

ivan-nginx commented Dec 27, 2018 •

edited

Loading

seven-steven commented Dec 28, 2018 •

edited

Loading

stevenjoezhang commented Mar 8, 2019 •

edited

Loading

ivan-nginx commented Mar 8, 2019 •

edited

Loading

stevenjoezhang commented Mar 29, 2019 •

edited

Loading