Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF won't display in particular situation #794

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: theme-next/theme-next-pdf#2

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang merged commit 1b5e64a into master Apr 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the stevenjoezhang-patch-1 branch April 1, 2019 09:20
@1v9
Copy link
Member

1v9 commented Apr 1, 2019

change title?

@stevenjoezhang
Copy link
Contributor Author

You do it

@ivan-nginx ivan-nginx assigned stevenjoezhang and unassigned 1v9 and liolok Apr 1, 2019
@ivan-nginx ivan-nginx changed the title Bug Fix: PDF won't display in particular situation PDF won't display in particular situation Apr 1, 2019
@ivan-nginx
Copy link
Member

@stevenjoezhang no need title like that.

invkrh added a commit to invkrh/hexo-theme-next that referenced this pull request Apr 13, 2019
* upstream/master: (65 commits)
  fix theme-next#815 (theme-next#828)
  Update IPC url (theme-next#827)
  List items appeared correctly in mobile with `mobile_layout_economy` option (theme-next#817)
  New translations en.yml (French) (theme-next#819)
  Improve French translation (theme-next#818)
  Fix wrong sidebar style on mobile (theme-next#808)
  Delete inactive reviewer
  New translations en.yml (Spanish) (theme-next#806)
  CSS bug in Codeblock if string longer than viewport (theme-next#803)
  Commented Project
  Temporairly turn off Project checking
  Disable Projects compairing
  Fix `vv` for Release Drafter
  Spanish translation (theme-next#801)
  Optimize images (theme-next#802)
  Release v7.1.0
  Change Algolia link in config
  Reduce reviewers for remove scrolling in PR's (theme-next#797)
  Disable add Assigners in Auto Assign bot (theme-next#795)
  Bug Fix: PDF won't display in particular situation (theme-next#794)
  ...
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for iPhone browser?
9 participants