Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repalce pseudo-classes with pseudo-elements #953

Merged
merged 7 commits into from
Jul 9, 2019
Merged

Repalce pseudo-classes with pseudo-elements #953

merged 7 commits into from
Jul 9, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor Author

Oh, how careless I am ... This class name is spliced out
屏幕快照 2019-07-09 下午4 10 30

This reverts commit 9ddf454.
@stevenjoezhang
Copy link
Contributor Author

I see. Now we got several page/post types:
post: picture | quote
page: categories | tags | schedule

@1v9
Copy link
Member

1v9 commented Jul 9, 2019

@stevenjoezhang Yes, and // TODO: Refactor. is right 😅

@todo
Copy link

todo bot commented Jul 9, 2019

Refactor.

// TODO: Refactor.
.page-home, .page-post-detail {
.post-type-quote {
This conversation was marked as resolved by 1v9
.post-header,


This comment was generated by todo based on a TODO comment in 6f483bb in #953. cc @theme-next.

@stevenjoezhang
Copy link
Contributor Author

I'm still confused by post-type-quote 😂
Let's deal with it later

@stevenjoezhang stevenjoezhang merged commit 91e9377 into master Jul 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the css branch July 9, 2019 09:21
@1v9
Copy link
Member

1v9 commented Jul 9, 2019

@stevenjoezhang Low Low priority ✔

@1v9 1v9 changed the title Refactoring CSS: Using Pseudo-elements selector Repalce pseudo-classes with pseudo-elements Jul 9, 2019
@ivan-nginx ivan-nginx mentioned this pull request Jul 17, 2019
33 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants