Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sidebar-dimmer #964

Merged
merged 11 commits into from
Jul 11, 2019
Merged

Refactor sidebar-dimmer #964

merged 11 commits into from
Jul 11, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 11, 2019

Breaking change

sidebar:
-  dimmer: false

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #820

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

sidebar-dimmer will always be enabled in mobile platform.
In desktop platform, click any blank part will close the sidebar.

How to use?

In NexT _config.yml:

sidebar:
...
-  # Click any blank part of the page to close sidebar (only for Muse | Mist).
-  dimmer: false

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Copy link
Member

1v9 commented Jul 11, 2019

Maybe keeping the option will be better...

@stevenjoezhang
Copy link
Contributor Author

Ivan once said that some people like to tap the screen while browsing the web (about #606)
In this case, the sidebar may be closed incorrectly...

@theme-next theme-next deleted a comment Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set sidebar->dimmer to true will make element on page unclickable
2 participants