Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add medium-zoom support #987

Merged
merged 11 commits into from
Jul 21, 2019
Merged

Add medium-zoom support #987

merged 11 commits into from
Jul 21, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 20, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #627

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 20, 2019
@theme-next theme-next deleted a comment Jul 20, 2019
@theme-next theme-next deleted a comment Jul 20, 2019
@theme-next theme-next deleted a comment Jul 20, 2019
@theme-next theme-next deleted a comment Jul 20, 2019
@theme-next theme-next deleted a comment Jul 20, 2019
maple3142
maple3142 reviewed Jul 20, 2019
View reviewed changes
_config.yml Show resolved Hide resolved
maple3142
maple3142 reviewed Jul 20, 2019
View reviewed changes
_config.yml Show resolved Hide resolved
@1v9
Copy link
Member

1v9 commented Jul 21, 2019

Nice work 🐱‍👤

@theme-next theme-next deleted a comment Jul 21, 2019
@theme-next theme-next deleted a comment Jul 21, 2019
@stevenjoezhang stevenjoezhang merged commit d4a8e1f into master Jul 21, 2019
@ivan-nginx ivan-nginx mentioned this pull request Aug 1, 2019
Closed
33 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Aug 1, 2019
Open
@stevenjoezhang stevenjoezhang mentioned this pull request Aug 16, 2019
Closed
15 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Add medium-zoom support (theme-next#987)
d31ed4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@sli1989 sli1989 Awaiting requested review from sli1989

@jiangtj jiangtj Awaiting requested review from jiangtj

@maple3142 maple3142 Awaiting requested review from maple3142

Assignees
No one assigned
Labels
Configurations 🌟 New Feature 🎯 Roadmap
Projects
None yet
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.

Suggestion: add instant.page & mediumZoom
3 participants
@stevenjoezhang @1v9 @maple3142