Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fastclick support #995

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Remove fastclick support #995

merged 1 commit into from
Jul 23, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 22, 2019

Breaking change

-fastclick: false
vendors:
-  fastclick:

According to the docs of fastclick:

Note: As of late 2015 most mobile browsers - notably Chrome and Safari - no longer have a 300ms touch delay, so fastclick offers no benefit on newer browsers, and risks introducing bugs into your application. Consider carefully whether you really need to use it.

And:
https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away
https://juejin.im/post/5cdf84e3f265da1bb564c79a

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 merged commit b4cd6e8 into master Jul 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the fastclick branch July 23, 2019 01:57
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants