Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not allowing to select other year #1465

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

khareemnurulla
Copy link
Contributor

@khareemnurulla khareemnurulla commented Aug 7, 2024

This fixes a bug introduced by #1457 not being able to select any other year except for 2024.

Related issues #1456

Summary by CodeRabbit

  • New Features
    • Enhanced Datepicker component for improved date selection accuracy.
    • Added functionality to ensure selected months align with the current view date, enhancing user experience.
  • Bug Fixes
    • Corrected issues with date handling in the Datepicker to ensure consistency in year selection.

Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: f7c7b7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 7:20am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 7:20am

Copy link
Contributor

coderabbitai bot commented Aug 7, 2024

Walkthrough

The recent changes to the DatepickerViewsMonth component enhance its functionality by integrating the viewDate from the useDatePickerContext hook. This allows the component to accurately manage and reflect the year associated with the selected month. By ensuring that date manipulations align with the current view date, the updates improve user experience and precision in date handling.

Changes

File Change Summary
.../Datepicker/Views/Months.tsx Added viewDate property from useDatePickerContext to enhance date handling and ensure accurate year selection.

Poem

In the month of bright display,
A rabbit hops in cheerful play,
With dates aligned, so neat and fine,
Our picker dances, all in line!
Let's celebrate with joy and cheer,
For every month brings laughter near! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c47d3a8 and f7c7b7f.

Files selected for processing (1)
  • packages/ui/src/components/Datepicker/Views/Months.tsx (2 hunks)
Additional comments not posted (2)
packages/ui/src/components/Datepicker/Views/Months.tsx (2)

23-32: LGTM! Ensure viewDate is correctly handled.

The addition of viewDate in the destructuring assignment from useDatePickerContext is correct. This change ensures that the component references the current view date directly.


42-42: LGTM! Ensure the logic modification is correct.

The modification to set the year of newDate to match the year of viewDate is correct. This change ensures that the selected month aligns with the current view date.

@rluders rluders merged commit 50b8bd6 into themesberg:main Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants