Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): close dropdown onClickOutside #640

Closed
wants to merge 4 commits into from
Closed

fix(dropdown): close dropdown onClickOutside #640

wants to merge 4 commits into from

Commits on Mar 8, 2023

  1. fix(drop-down): close dropdown onClickOutside 

    As a fix I removed dismissOnClick={false} this from the Dropdown component  so it is closed
onCickOutside or when user selects one item from the dropdown

fix  #527
    @Tejas9535
    Tejas9535 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    acdbc58 View commit details
    Browse the repository at this point in the history

  2. fix(dropdown): added closeOnOutside even for dismissOnClick is set to… 

    … false

Added Ref and wrapped whole component around it and added closeOnOutside even for dismissOnClick is
set to false so now even if dismissOnClick is set to false it'll close on outside click
    @Tejas9535
    Tejas9535 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    9f5c465 View commit details
    Browse the repository at this point in the history

  3. fix(dropdown): made changes suggested in PR 

    formated files acording to style

#527
    @Tejas9535
    Tejas9535 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    f68c283 View commit details
    Browse the repository at this point in the history

  4. fix(dropdown): removed unused code

    @Tejas9535
    Tejas9535 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0109994 View commit details
    Browse the repository at this point in the history