-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdown): add disabled to dropdown #727
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 129 129
Lines 6539 6543 +4
Branches 391 393 +2
=======================================
+ Hits 6509 6513 +4
Misses 30 30
☔ View full report in Codecov by Sentry. |
Please add at least one test case for this verifying the disabled behavior. |
@tulup-conner I added test case. Please check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you rebase and move these changes to src/theme.ts? We just changed up our repository pretty substantially. You can see the new contributing guide here: https://github.com/themesberg/flowbite-react/blob/main/CONTRIBUTING.md
If you aren't comfortable rebasing, let me know and I'll be happy to do so for you.
@tulup-conner I will do it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@tulup-conner up to you know. |
@paghar can you rebase this one with |
@paghar Please, revert your merge commit and use rebase instead of merge to update your branch. |
Let me know when this has been updated and I will give it another pass |
This was completed by #840 |
#539
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Breaking changes
Please document the breaking changes if suitable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: