Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): add disabled to dropdown #727

Closed
wants to merge 8 commits into from

Conversation

paghar
Copy link
Contributor

@paghar paghar commented May 2, 2023

#539

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (470c359) 99.54% compared to head (1f137e2) 99.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         129      129           
  Lines        6539     6543    +4     
  Branches      391      393    +2     
=======================================
+ Hits         6509     6513    +4     
  Misses         30       30           
Impacted Files Coverage Δ
src/components/Dropdown/Dropdown.tsx 100.00% <100.00%> (ø)
src/components/Floating/Floating.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tulup-conner
Copy link
Collaborator

Please add at least one test case for this verifying the disabled behavior.

@tulup-conner tulup-conner marked this pull request as draft May 4, 2023 14:38
@paghar paghar marked this pull request as ready for review May 6, 2023 07:16
@paghar
Copy link
Contributor Author

paghar commented May 8, 2023

@tulup-conner I added test case. Please check it.

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you rebase and move these changes to src/theme.ts? We just changed up our repository pretty substantially. You can see the new contributing guide here: https://github.com/themesberg/flowbite-react/blob/main/CONTRIBUTING.md

If you aren't comfortable rebasing, let me know and I'll be happy to do so for you.

@rluders rluders added this to the 1.0.0 milestone May 26, 2023
@paghar
Copy link
Contributor Author

paghar commented May 28, 2023

@tulup-conner I will do it.

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2023 11:26am

src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
src/components/Floating/Floating.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rluders
Copy link
Collaborator

rluders commented May 29, 2023

@tulup-conner up to you know.

@paghar paghar requested a review from rluders June 11, 2023 08:03
@rluders
Copy link
Collaborator

rluders commented Jun 16, 2023

@paghar can you rebase this one with main branch? I think that there are some conflicts to be solved. Once done, ping me than I can get it merged. Thanks.

@rluders
Copy link
Collaborator

rluders commented Jun 18, 2023

@paghar Please, revert your merge commit and use rebase instead of merge to update your branch.

@tulup-conner
Copy link
Collaborator

Let me know when this has been updated and I will give it another pass

@rluders
Copy link
Collaborator

rluders commented Jul 16, 2023

This was completed by #840

@rluders rluders closed this Jul 16, 2023
@paghar paghar deleted the dropdown-disabled branch November 2, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants