-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NavContainer not exported #1298
fix: NavContainer not exported #1298
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
WalkthroughThis update marks a pivotal improvement in the project, focusing on enhancing the usability of the Changes
Assessment against linked issues
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/lib/index.js (1 hunks)
Additional comments (1)
src/lib/index.js (1)
- 119-119: The addition of
NavContainer
to the exports inindex.js
correctly addresses the issue documented in NavContainer not exported from index.jsΒ #1297, allowing users to importNavContainer
directly from theflowbite-svelte
package. This change enhances the usability of the component and aligns with the project's structure and conventions.
<Navbar let:NavContainer color="primary">
<NavContainer class="border px-5 py-2 rounded-lg bg-white dark:bg-gray-600">
.... |
I close the PR for now. |
Closes #1297
π Description
See #1297
Status
β Checks
Summary by CodeRabbit