-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: add close event to toast component #1383
Conversation
@robluton is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe update introduces a new 'close' event to the Changes
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/lib/toast/Toast.svelte (3 hunks)
- src/routes/component-data/Toast.json (1 hunks)
- src/routes/docs/components/toast.md (1 hunks)
Additional comments not posted (5)
src/routes/component-data/Toast.json (1)
4-4
: Approved: Addition ofon:close
event.The addition of the
on:close
event to the Toast component metadata is correct and aligns with the new functionality.src/lib/toast/Toast.svelte (3)
3-3
: Approved: ImportcreateEventDispatcher
from 'svelte'.The import statement for
createEventDispatcher
is correct and necessary for dispatching events.
24-24
: Approved: Createdispatch
constant.The
dispatch
constant is correctly created usingcreateEventDispatcher
.
99-99
: Approved: Dispatch 'close' event on toast close.The 'close' event is correctly dispatched when the toast is closed, allowing for custom logic to be executed.
src/routes/docs/components/toast.md (1)
348-360
: Approved: Addition of "Events" section withon:close
event example.The documentation correctly adds a new "Events" section and provides a clear example of how to use the
on:close
event.
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Closes # 1348
π Description
This PR adds an on:close event to the Toast component, allowing custom logic to be executed when the toast is closed.
Status
β Checks
Summary by CodeRabbit