Adds close tooltips with esc key to meet WCAG #440
Adds close tooltips with esc key to meet WCAG #440zoltanszogyenyi merged 3 commits intothemesberg:mainfrom
Conversation
|
Hello @daveholst, Thanks for the PR and super appreciate the work! Flowbite is primarily an open-source software so it is really great when others also contribute as I cannot possibly cover all cases at once. I've checked the PR and things look good - can you please do the same for the Popover component? They are very similar in behaviour that way we can make sure that both off-canvas cases of tooltips and popovers are WCAG compatible. Cheers, |
|
Thanks for the quick reply @zoltanszogyenyi. As requested, I have applied the same changes to the popover component. Cheers. |
|
Thanks @daveholst - I'll have it checked this week and merged if no further changes are required. |
|
Hey @daveholst - I've checked out the PR and added the new class functions to their apropiate interfaces. Merged and thanks for the contribution! This will be deployed for |
We are currently undergoing a WCAG audit on our site and reskinning it with flowbite. We were penalised for not having our tooltips close with the escape key and I noticed that the flowbite tooltips also behave the same. I have used the modal esc key event listeners, modified them slightly and bought them into here.
Please let me know if you think this is a suitable solutons.
Loving flowbite, thanks for all the hard work!
https://www.w3.org/WAI/ARIA/apg/patterns/tooltip/