-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying new fields of repeater field in existing rows doesn't work #1540
Comments
Confirmed. Just came across the same issue. |
Yes, this is a known issue. Unfortunately this will have to wait for the 3.1 refactor where repeaters will be rebuilt from scratch |
I've faced the same issue. It looks like it is because of the check from row 2938 in script.js: if ( _.isUndefined( currentSettings[ row.rowIndex ][ fieldId ] ) ) {
return;
} This check aborts the I don't know why this check is necessary. I've simply commented out that JS check as a workaround, but please let me know if you know any specific cases when that check is important! |
Is this a possible solution @aristath? Thanks @Grapestain! |
Has anyone figured out how to fix this yet, by chance? I see the last comment here was almost 2 years ago and I am still having this issue. Commenting out the code snippet that @BenceSzalai posted above did not work for me. Any help would be greatly appreciated! |
Probably, because you client side uses the minified JS. Look for |
Looks like it has moved since here: https://github.com/kirki-framework/kirki/blob/develop/packages/kirki-framework/control-repeater/src/assets/scripts/control.js#L736 |
Issue description:
But if I create second row, second field in second row works.
Version used:
3.0.9 and develop branch
Using theme_mods or options?
options
Code to reproduce the issue (config + field(s))
Step 1:
Step 3:
The text was updated successfully, but these errors were encountered: