Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined variable: plugin_install_url in class-kirki-installer-section.php on line 98 #1834

Closed
Far-East opened this issue Mar 16, 2018 · 4 comments
Closed

Undefined variable: plugin_install_url in class-kirki-installer-section.php on line 98 #1834

Far-East opened this issue Mar 16, 2018 · 4 comments

Comments

@Far-East
Copy link

Issue description: Notice: Undefined variable: plugin_install_url in class-kirki-installer-section.php on line 98

Version used: 3.0.25

Hello. I make a recommendation to install the plug-in according to your instructions, but in Customizer on the recommendation button for installation, the message appears: Notice: Undefined variable: plugin_install_url in class-kirki-installer-section.php on line 98
@aristath
Copy link
Contributor

Can you please try the version from the develop branch? I just pushed a commit that should fix this.

@Far-East
Copy link
Author

Thank you, the button appeared, but it does not work. The browser simply updates and nothing happens. The console shows that there is no link on the button.

aristath added a commit that referenced this issue Mar 17, 2018
@aristath
Merge branch 'develop' into postMessage-refactor
f0182ea 
* develop: (73 commits)
  fixes #1730
  fixes #1830
  GDPR: Load webfont-loader locally
  Update fonts
  fixes #1834
  Apply WordPress Coding Standards
  Update kirki-helper-class.md
  see #1797
  cleanup unused vars
  See #1807
  Additional fix for #1809
  fixes #1828
  fixes #1808
  fix #1814
  fix #1797
  fixes #1809
  Update sortable.md
  fixes #1787
  update webfonts & grunt
  changelog
  ...

# Conflicts:
#	modules/postmessage/class-kirki-modules-postmessage.php
aristath added a commit that referenced this issue Mar 17, 2018
@aristath
fixes #1834
635122e
@aristath
Copy link
Contributor

Fixed & tested.

aristath added a commit that referenced this issue Mar 17, 2018
@aristath
Merge branch 'develop' into postMessage-refactor
c912552 
* develop:
  fixes #1834
@Far-East
Copy link
Author

Far-East commented Mar 29, 2018 •
edited
Loading

Aristath!!! Great work !!! Thanks for the plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aristath @Far-East